Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize the Layout of the Lineage Configuration File #60

Merged
merged 2 commits into from
Jul 22, 2021
Merged

Standardize the Layout of the Lineage Configuration File #60

merged 2 commits into from
Jul 22, 2021

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Jun 7, 2021

🗣 Description

This updates the .github/lineage.yml file to have a format that mirrors what is produced if one uses the skeleton script from cisagov/development_guide.

💭 Motivation and context

This will eliminate pointless changes that occur when creating a new project using that script (as is recommended).

🧪 Testing

LGTM :shipit:

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Jun 7, 2021
@mcdonnnj mcdonnnj self-assigned this Jun 7, 2021
@mcdonnnj mcdonnnj requested review from dav3r, felddy and jsf9k as code owners June 7, 2021 12:29
dav3r
dav3r approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mcdonnnj mcdonnnj added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Jun 10, 2021
@mcdonnnj mcdonnnj merged commit 0f98fd6 into develop Jul 22, 2021
@mcdonnnj mcdonnnj deleted the improvement/standardize_lineage_configuration branch July 22, 2021 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@mcdonnnj mcdonnnj

Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dav3r