Add the tag.sh Script #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the GitHub Actions configuration builds images on tag pushes, we should use the standard tagging script we use for the same purpose in other repositories. This will make it easier to tag, build, and push Docker images of a specific version in a standardized manner.
mcdonnnj
added
the
improvement
mcdonnnj
added
the
blocked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR adds the
tag.shscript from cisagov/skeleton-python-library to this repository.💭 Motivation and context
Since Docker projects will build and push images to Docker Hub on tag pushes (through the GitHub Actions workflow), we should have a consistent manner of triggering this action. We use the
tag.shscript in Python projects for a similar purpose so I thought it fitting to copy that script to this project type. Additionally this script has been used by older Docker projects that are not skeletonized for the same purpose (see cisagov/orchestrator, cisagov/cyhy-mailer and others).🧪 Testing
I used this script to tag and push versions of cisagov/vdp-scanner-docker to get correct image pushes to Docker Hub.
✅ Checklist