Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semver to Development Requirements File #55

Merged
merged 2 commits into from
Jun 3, 2021

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This PR adds the semver package to the development requirements file requirements-dev.txt.

💭 Motivation and context

This package is used by the bump_version.sh script, but it is not included as a requirement for creating a development environment.

🧪 Testing

Automated tests pass.

✅ Checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

The semver package is needed by the bump_version.sh script, but it is not
included in requirements-dev.txt.
@mcdonnnj mcdonnnj added the bug This issue or pull request addresses broken functionality label Apr 25, 2021
@mcdonnnj mcdonnnj self-assigned this Apr 25, 2021
@mcdonnnj mcdonnnj added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Apr 25, 2021
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @mcdonnnj! 👍

@mcdonnnj mcdonnnj merged commit d580ccb into develop Jun 3, 2021
@mcdonnnj mcdonnnj deleted the bug/add_semver_to_requirements branch June 3, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue or pull request is awaiting the outcome of another issue or pull request bug This issue or pull request addresses broken functionality
Projects
Development

Successfully merging this pull request may close these issues.

3 participants