Modernize Docker workflow

[felddy]

🗣 Description

This PR updates the workflows to use more recent methods:

• It uses the suite of Docker GitHub Actions (from CrazyMax).
• It builds Docker images for more than one platform.
• It handles making builds for branches, and tags them correctly.
• It detects a release by the name of the git tag.
• Nightly builds.

💭 Motivation and Context

I've been building this workflow based on some of the best-practices of the docker actions repos.

See here: https://github.com/docker/build-push-action#complete-workflow

Basically: If you change something in the repo, an image is going to pop out. This is a good thing. It makes testing branches a piece of cake.

🧪 Testing

Tested for a few months in my personal project.
CI.

📷 Screenshots (if appropriate)

🚥 Types of Changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (causes existing functionality to change)

✅ Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[jsf9k]

I think that these are great improvements, so strong work there @felddy!

That said, I think there are a few minor issues that should be cleared up before emerging. Please see my inline comments.

In addition to that, and given that this is a skeleton repo that external folks may want to study before using, I think it might make sense to add more comments in .github/workflows/build.yml. The intent is less to detail what is being done by the code and more to guide the eye and help break up the giant workflow into digestible chunks (or "functions") that each perform a particular function. That file is a little overwhelming at first glance, and it's difficult to find one's place again if one looks away at an email and comes back to it.

[jsf9k]

WRT commits 905799f, 3e7033b, and c506a21...I think GitHub gives you the option to combine multiple suggestions into a single commit. I haven't had a chance to confirm that yet, but this would have been an excellent place to use that feature (assuming it exists).

Also, we should strive to use a better commit comment than the default offered by GitHub. "Update .github/workflows/build.yml" is not very informative.

Not criticizing, just pointing out how we can better use our tools.

[jsf9k]

🎶 Workin' on my night builds 🎶

[felddy]

WRT commits 905799f, 3e7033b, and c506a21...I think GitHub gives you the option to combine multiple suggestions into a single commit. I haven't had a chance to confirm that yet, but this would have been an excellent place to use that feature (assuming it exists).

Also, we should strive to use a better commit comment than the default offered by GitHub. "Update .github/workflows/build.yml" is not very informative.

Not criticizing, just pointing out how we can better use our tools.

I saw the "add to batch" button after I got through a couple of the suggestions. I agree, those defaults suxors.

Also see my comment in the description that I plan on squash-merging this PR since the commits are too exploratory (for my liking) due to the need to debug the workflow github-side. I put that in there as I am open to preserving the individual commits if the team things there is value there.

[mcdonnnj]

WRT commits 905799f, 3e7033b, and c506a21...I think GitHub gives you the option to combine multiple suggestions into a single commit. I haven't had a chance to confirm that yet, but this would have been an excellent place to use that feature (assuming it exists).
Also, we should strive to use a better commit comment than the default offered by GitHub. "Update .github/workflows/build.yml" is not very informative.
Not criticizing, just pointing out how we can better use our tools.

I saw the "add to batch" button after I got through a couple of the suggestions. I agree, those defaults suxors.

Also see my comment in the description that I plan on squash-merging this PR since the commits are too exploratory (for my liking) due to the need to debug the workflow github-side. I put that in there as I am open to preserving the individual commits if the team things there is value there.

Maybe do a rebase, mark the fluff as fixup, and force push to keep useful commits? That way we can avoid squashing the whole thing down, but also trim the fat so to speak.

[jsf9k]

Maybe do a rebase, mark the fluff as fixup, and force push to keep useful commits? That way we can avoid squashing the whole thing down, but also trim the fat so to speak.

100% agree with @mcdonnnj here.

[felddy]

In addition to that, and given that this is a skeleton repo that external folks may want to study before using, I think it might make sense to add more comments in .github/workflows/build.yml. The intent is less to detail what is being done by the code and more to guide the eye and help break up the giant workflow into digestible chunks (or "functions") that each perform a particular function. That file is a little overwhelming at first glance, and it's difficult to find one's place again if one looks away at an email and comes back to it.

This is a good suggestion. I'll add some detailed documentation about what is going on. Mainly for future-me. Because I'm sure this will run for six months then fail, and I'll come back all Gandalf-in-Moria when it breaks.

[felddy]

Maybe do a rebase, mark the fluff as fixup, and force push to keep useful commits? That way we can avoid squashing the whole thing down, but also trim the fat so to speak.

You like it when GitHub goes down?! Cause this is how GitHub goes down. 😉
I'll attempt this! Keep an eye on: https://www.githubstatus.com/

[jsf9k]

You like it when GitHub goes down?! Cause this is how GitHub goes down.
I'll attempt this! Keep an eye on: https://www.githubstatus.com/

I do this sort of thang tous les temps. C'est une chose quotidienne pour moi. You and GitHub will be OK! 🇫🇷

[felddy]

Interactive rebase == Great Success!!

Jesus H. Christ we're still here!
https://www.youtube.com/watch?v=ir5bTic17k4

[jsf9k]

This PR looks great. Thanks for resolving all the thangs.

[dav3r]

Super sweet improvements- can't wait to get this sauce cooking! ⚙️

I discovered a lone typo in a comment, but everything else looks grand!

[jsf9k]

I am requesting one minor change, for clarity.

[jsf9k]

Thank you for elaborating upon the solidus. We must educate the masses!