-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Python 3.9 instead of 3.8 #36
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got a 🥵 , and the only prescription is more 🐮 🔔 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this oversight. 🔎🦅
While we're here do we want to fix:
skeleton-docker/.github/workflows/release.yml
Lines 21 to 24 in 0b979a7
- name: Determine image version | |
id: get_ver | |
run: | | |
echo "##[set-output name=version;]$(./bump_version.sh show)" |
and the subsequent uses at:
--build-arg VERSION=${{ steps.get_ver.outputs.version }} \ |
<<< "${{ steps.get_ver.outputs.version }}" |
"${IMAGE_NAME}:${{ steps.get_ver.outputs.version }}" |
<<< "${{ steps.get_ver.outputs.version }}" |
docker push "${IMAGE_NAME}:${{ steps.get_ver.outputs.version }}" |
These changes all have to do with the version of the Docker image.
Yes! Good eye! Fixed in commit 7d59f7e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool cool cool. 🍨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, real nice.
🗣 Description
This pull request fixes one place where we are using Python 3.8 but should be using 3.9.
💭 Motivation and Context
New and shiny!
🧪 Testing
All pre-commit hooks pass.
🚥 Types of Changes
✅ Checklist