Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python 3.9 instead of 3.8 #36

Merged
merged 2 commits into from
Oct 13, 2020
Merged

Use Python 3.9 instead of 3.8 #36

merged 2 commits into from
Oct 13, 2020

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Oct 9, 2020

🗣 Description

This pull request fixes one place where we are using Python 3.8 but should be using 3.9.

💭 Motivation and Context

New and shiny!

🧪 Testing

All pre-commit hooks pass.

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jsf9k jsf9k added the bugfix label Oct 9, 2020
@jsf9k jsf9k self-assigned this Oct 9, 2020
Copy link
Member

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a 🥵 , and the only prescription is more 🐮 🔔 !

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this oversight. 🔎🦅

While we're here do we want to fix:

- name: Determine image version
id: get_ver
run: |
echo "##[set-output name=version;]$(./bump_version.sh show)"

and the subsequent uses at:
--build-arg VERSION=${{ steps.get_ver.outputs.version }} \

<<< "${{ steps.get_ver.outputs.version }}"

"${IMAGE_NAME}:${{ steps.get_ver.outputs.version }}"

<<< "${{ steps.get_ver.outputs.version }}"

docker push "${IMAGE_NAME}:${{ steps.get_ver.outputs.version }}"

These changes all have to do with the version of the Docker image.
@jsf9k
Copy link
Member Author

jsf9k commented Oct 12, 2020

While we're here do we want to fix:

- name: Determine image version
id: get_ver
run: |
echo "##[set-output name=version;]$(./bump_version.sh show)"

and the subsequent uses at:

--build-arg VERSION=${{ steps.get_ver.outputs.version }} \

<<< "${{ steps.get_ver.outputs.version }}"

"${IMAGE_NAME}:${{ steps.get_ver.outputs.version }}"

<<< "${{ steps.get_ver.outputs.version }}"

docker push "${IMAGE_NAME}:${{ steps.get_ver.outputs.version }}"

Yes! Good eye! Fixed in commit 7d59f7e.

@jsf9k jsf9k requested a review from mcdonnnj October 12, 2020 19:01
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool cool cool. 🍨

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, real nice.

@jsf9k jsf9k merged commit 8fa63f6 into develop Oct 13, 2020
@jsf9k jsf9k deleted the bugfix/correct-missed-3.8 branch October 13, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants