Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing cache keys for test job. #35

Merged
merged 2 commits into from
Oct 9, 2020
Merged

Add missing cache keys for test job. #35

merged 2 commits into from
Oct 9, 2020

Conversation

felddy
Copy link
Member

@felddy felddy commented Oct 8, 2020

Fixes #30

🗣 Description

Add missing cache keys for test job.

💭 Motivation and Context

🧪 Testing

📷 Screenshots (if appropriate)

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@felddy felddy added bug This issue or pull request addresses broken functionality hacktoberfest-accepted labels Oct 8, 2020
dav3r
dav3r approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

jsf9k
jsf9k approved these changes Oct 8, 2020
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚡

@felddy
Copy link
Member Author

felddy commented Oct 9, 2020

@mcdonnnj does this look good to you?

mcdonnnj
mcdonnnj requested changes Oct 9, 2020
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this done. :godmode: Please see my one change.

.github/workflows/build.yml Outdated Show resolved Hide resolved
@felddy @mcdonnnj
Update .github/workflows/build.yml
e0beef2 
Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
@felddy felddy requested a review from mcdonnnj October 9, 2020 18:22
mcdonnnj
mcdonnnj approved these changes Oct 9, 2020
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪💪💪

@felddy felddy merged commit c5aba87 into develop Oct 9, 2020
@felddy felddy deleted the fix/missed_cache_key branch October 9, 2020 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@jsf9k jsf9k jsf9k approved these changes

@hillaryj hillaryj Awaiting requested review from hillaryj

Assignees

@felddy felddy

@mcdonnnj mcdonnnj

Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missed Cache Key in PR #29
4 participants
@felddy @jsf9k @dav3r @mcdonnnj