Use the full path for source container images #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps ensure that when a Docker image is built the expacted source image is used regardless of what repository is configured as the default on the host system. It also makes our Dockerfiles more seamlessly convertible to using the GitHub Container Registry or any other Open Container Initiative (OCI) compatible registry.
Use the full tag that includes the Alpine Linux version to ensure the pulled image is always the same.
mcdonnnj
added
the
improvement
mcdonnnj
requested review from
dav3r,
felddy,
jasonodoom and
jsf9k
as code owners
jsf9k
approved these changes
Feb 20, 2024
michaelsaki
approved these changes
Feb 20, 2024
mcdonnnj
merged commit ce1247a
into
improvement/update_Dockerfile_configuration
16 checks passed
7 tasks
This was referenced Mar 5, 2024
cisagovbot
pushed a commit
that referenced
this pull request
Sep 25, 2024
Use an Action to install Packer in our GitHub Actions workflows
mcdonnnj
added a commit
that referenced
this pull request
Dec 6, 2024
Use the full path for source container images
mcdonnnj
added a commit
that referenced
this pull request
Dec 6, 2024
Use the full path for source container images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request updates the image used in the
FROMinstruction of the Dockerfile to use the full path for Docker Hub sourced container images. It also updates the tag for the image to specify the version of Alpine Linux.Note
I am creating this pull request against a branch that will represent a larger body of work. This branch will later have a pull request against
developonce the body of work is completed.💭 Motivation and context
Using the full image name will ensure that we pull exactly the image we mean to when building. This is important because some operating systems (such as Red Hat Enterprise Linux) are configured with a default registry other than Docker Hub. It will also make Dockerfile configurations consistent if a non-Docker Hub sourced image is used (such as from a GitHub Container Registry package). Lastly we specify the version of Alpine Linux used to ensure build reproducibility.
🧪 Testing
Automated tests pass.
✅ Pre-approval checklist