Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify comment referencing "stopped" parameter #168

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Modify comment referencing "stopped" parameter #168

merged 1 commit into from
Dec 6, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jul 28, 2023 •
edited
Loading

🗣 Description

This pull request edits a comment that references a parameter that no longer exists.

💭 Motivation and context

The stopped parameter is no longer present now that we are using python-on-whales.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added documentation This issue or pull request improves or adds to documentation kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Jul 28, 2023
@jsf9k jsf9k self-assigned this Jul 28, 2023
@jsf9k jsf9k mentioned this pull request Jul 28, 2023
Merged
3 tasks
@jsf9k jsf9k marked this pull request as ready for review July 28, 2023 19:46
@jsf9k jsf9k requested a review from a team July 28, 2023 19:46
@jsf9k @dav3r
Reference correct parameter name in comment
a518cfb 
The "stopped" parameter is no longer present now that we are using
python-on-whales.

Co-authored-by: dav3r <david.redmin@gwe.cisa.dhs.gov>
@jsf9k jsf9k force-pushed the documentation/fix-comment branch from 9d220ed to a518cfb Compare July 28, 2023 20:26
@jsf9k jsf9k requested a review from dv4harr10 July 28, 2023 20:27
@dav3r dav3r changed the title Remove comment referencing "stopped" parameter Modify comment referencing "stopped" parameter Jul 28, 2023
@mcdonnnj mcdonnnj added this pull request to the merge queue Dec 6, 2023
Merged via the queue into develop with commit c70e91e Dec 6, 2023
@mcdonnnj mcdonnnj deleted the documentation/fix-comment branch December 6, 2023 08:02
cisagovbot pushed a commit that referenced this pull request Mar 6, 2024
@mcdonnnj
Merge pull request #168 from cisagov/improvement/switch_pre-commit_ho…
e79569c 
…ok_for_shellcheck

Switch the pre-commit hook used to run `shellcheck`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav3r dav3r dav3r approved these changes

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@jasonodoom jasonodoom jasonodoom approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
documentation This issue or pull request improves or adds to documentation kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Next Kraken
Status: Done
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jsf9k @jasonodoom @dav3r @mcdonnnj @dv4harr10