Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wheel along with pip and setuptools #143

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Update wheel along with pip and setuptools #143

merged 1 commit into from
Feb 10, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Dec 3, 2022 •
edited
Loading

🗣 Description

This pull request updates the Python package wheel along with pip and setuptools.

💭 Motivation and context

If we're updating two then we may as well update them all.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Dec 3, 2022
@jsf9k jsf9k mentioned this pull request Dec 3, 2022
Merged
11 tasks
@jsf9k jsf9k marked this pull request as ready for review December 3, 2022 20:13
mcdonnnj
mcdonnnj approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jsf9k jsf9k added the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Dec 4, 2022
dav3r
dav3r approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@mcdonnnj mcdonnnj removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Feb 2, 2023
@jsf9k @mcdonnnj @jmorrowomni
Update wheel along with pip and setuptools
4e5287f 
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
@jmorrowomni jmorrowomni force-pushed the improvement/update-wheel branch from 8728bc8 to 4e5287f Compare February 10, 2023 02:08
@jmorrowomni jmorrowomni merged commit d4f2e48 into develop Feb 10, 2023
@jmorrowomni jmorrowomni deleted the improvement/update-wheel branch February 10, 2023 02:22
@jmorrowomni jmorrowomni mentioned this pull request Feb 10, 2023
Merged
6 tasks
cisagovbot pushed a commit that referenced this pull request Sep 13, 2023
@mcdonnnj
Merge pull request #143 from cisagov/add-nixfmt
8432f1e 
Add nixfmt pre-commit hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Next Kraken
Status: Done
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @mcdonnnj @jmorrowomni