Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify pip3 #142

Merged
merged 1 commit into from
Feb 10, 2023
Merged

Specify pip3 #142

merged 1 commit into from
Feb 10, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Nov 23, 2022 •
edited
Loading

🗣 Description

This pull request modifies the Dockerfile to specify the use of pip3.

💭 Motivation and context

In this case it doesn't matter because we are starting from a Python3-specific base container, but other projects that use this skeleton may not be. Specifying pip3 ensures that the Python2 version of pip is not called by mistake.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k jsf9k added blocked This issue or pull request is awaiting the outcome of another issue or pull request improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release labels Nov 23, 2022
@jsf9k jsf9k self-assigned this Nov 23, 2022
@jsf9k jsf9k marked this pull request as ready for review November 23, 2022 03:46
mcdonnnj
mcdonnnj approved these changes Nov 23, 2022
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable enough.

dav3r
dav3r reviewed Nov 28, 2022
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good thinking. 👍

@mcdonnnj mcdonnnj removed the blocked This issue or pull request is awaiting the outcome of another issue or pull request label Feb 2, 2023
@jmorrowomni
Specify pip3
83beae5 
In this case it doesn't matter because we are starting from a
Python3-specific base container, but other projects that use this
skeleton may not be.  Specifying pip3 ensures that the Python 2
version of pip is not called by mistake.
@jmorrowomni jmorrowomni force-pushed the improvement/specify-python3 branch from e81be80 to 83beae5 Compare February 10, 2023 02:26
@jmorrowomni jmorrowomni merged commit c43af0b into develop Feb 10, 2023
@jmorrowomni jmorrowomni deleted the improvement/specify-python3 branch February 10, 2023 02:35
@jmorrowomni jmorrowomni mentioned this pull request Feb 10, 2023
Merged
6 tasks
@mcdonnnj mcdonnnj restored the improvement/specify-python3 branch February 10, 2023 16:12
@mcdonnnj mcdonnnj deleted the improvement/specify-python3 branch February 10, 2023 16:44
cisagovbot pushed a commit that referenced this pull request Sep 13, 2023
@mcdonnnj
Merge pull request #142 from cisagov/maintenance/update_pre-commit_hooks
94903ae 
Update `pre-commit` hooks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@dav3r dav3r dav3r approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

@mcdonnnj mcdonnnj

Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use kraken 🐙 This pull request is ready to merge during the next Lineage Kraken release
Projects
Next Kraken
Status: Done
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @mcdonnnj @jmorrowomni