Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LGTM from the repository #139

Merged
merged 1 commit into from
Nov 22, 2022
Merged

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Nov 22, 2022

🗣 Description

This pull request removes all LGTM-related items from the repository.

💭 Motivation and context

LGTM.com is shutting down 2022-12-16 per the LGTM deprecation blog post. We need to remove all LGTM-related items from our repositories so we can cleanly disable the LGTM.com integration in the organization.

⚠ Note

LGTM check requirements should be turned off in branch protection for downstream projects as part of reconciling the Lineage pull requests. I have already removed them in the branch protection for this repository.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • All new and existing tests pass.

LGTM.com is shutting down 2022-12-16 so we should remove all
LGTM-related items to prepare for disabling the LGTM.com integration in
the organization.
@mcdonnnj mcdonnnj added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Nov 22, 2022
@mcdonnnj mcdonnnj requested a review from dav3r as a code owner November 22, 2022 02:55
@mcdonnnj mcdonnnj self-assigned this Nov 22, 2022
@mcdonnnj
Copy link
Member Author

mcdonnnj commented Nov 22, 2022

@jsf9k I missed the memo about this when I was making #115. I would like to push this out with the fresh Lineage PRs that are already out there for descendants of this repository so we don't get caught by LGTM services turning off. I plan on making similar pull requests in the cisagov/skeleton-ansible-role and cisagov/skeleton-python-library projects. I'll also double-check if we have LGTM references in any other skeleton projects to make sure we catch 'em all.

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcdonnnj mcdonnnj merged commit 81f6c71 into develop Nov 22, 2022
@mcdonnnj mcdonnnj deleted the maintenance/remove_lgtm branch November 22, 2022 05:12
cisagovbot pushed a commit that referenced this pull request Sep 13, 2023
Use the correct repo name for the ansible-lint pre-commit hook
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
Development

Successfully merging this pull request may close these issues.

2 participants