Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing env variable for test #13

Merged
merged 2 commits into from
Nov 14, 2019
Merged

Add missing env variable for test #13

merged 2 commits into from
Nov 14, 2019

Conversation

felddy
Copy link
Member

@felddy felddy commented Nov 14, 2019

🗣 Description

I forgot to add pass the RELEASE_TAG environment variable.

This is the same as cisagov/skeleton-python-library#26

💭 Motivation and Context

This is needed to verify the release tag matches the version in the codebase.

🧪 Testing

📷 Screenshots (if appropriate)

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@felddy felddy added the bug This issue or pull request addresses broken functionality label Nov 14, 2019
@felddy felddy self-assigned this Nov 14, 2019
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔬

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dynamite!

@felddy felddy merged commit 5856ba9 into develop Nov 14, 2019
@felddy felddy deleted the improvement/actions branch November 14, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
Development

Successfully merging this pull request may close these issues.

3 participants