Fix overly eager sed commands #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
mcdonnnj
approved these changes
Sep 13, 2022
jsf9k
added
the
blocked
cisagovbot
pushed a commit
that referenced
this pull request
Nov 9, 2022
Update two configuration files
We saw in cisagov/postfix-docker#47 that the sed commands in the bump_version.sh script could inadvertently match the CC0 version in the README.md file. This change escapes the periods in the version before passing it on to sed so that they only match periods and not just any character.
mcdonnnj
force-pushed
the
bugfix/tighten-regex-in-version-script
branch
from
376198c to
1a8ab89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request tightens a few
sedcommands so that their regexes do not inadvertently match when they should not.💭 Motivation and context
We saw in cisagov/postfix-docker#47 that the
sedcommands in thebump_version.shscript could inadvertently match the CC0 version in theREADME.mdfile. This change escapes the periods in the version before passing it on tosedso that they only match periods and not just any character.🧪 Testing
I tested locally and verified that with these changes the situation that arose in cisagov/postfix-docker#47 does not occur.
✅ Pre-approval checklist