Unpin ansible-lint #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can now move to version 5 with impunity. I have a path forward, largely following in the footsteps of @geerlingguy.
jsf9k
added
blocked
dav3r
approved these changes
Sep 7, 2021
mcdonnnj
requested changes
Sep 7, 2021
@mcdonnnj pointed out that this will keep us from being blindsided by future changes. Co-authored-by: Nick M. <50747025+mcdonnnj@users.noreply.github.com>
6 tasks
Merged
7 tasks
jsf9k
added
the
hacktoberfest-accepted
mcdonnnj
added a commit
to cisagov/skeleton-generic
that referenced
this pull request
Oct 1, 2021
This file is copied from cisagov/skeleton-ansible-role#85 and tweaked to pass pre-commit. See here for for a list of the elements that can exist in this file: https://ansible-lint.readthedocs.io/en/latest/configuring.html Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
8 tasks
mcdonnnj
added a commit
to cisagov/skeleton-generic
that referenced
this pull request
Oct 19, 2021
This file is copied from cisagov/skeleton-ansible-role#85 and tweaked to pass pre-commit. See here for for a list of the elements that can exist in this file: https://ansible-lint.readthedocs.io/en/latest/configuring.html Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
mcdonnnj
added a commit
to cisagov/skeleton-generic
that referenced
this pull request
Oct 19, 2021
This file is copied from cisagov/skeleton-ansible-role#85 and tweaked to pass pre-commit. See here for for a list of the elements that can exist in this file: https://ansible-lint.readthedocs.io/en/latest/configuring.html Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
This was referenced Oct 20, 2021
mcdonnnj
force-pushed
the
improvement/upgrade-ansible-lint
branch
from
534864f to
019d307
Compare
Sallenmoore
pushed a commit
to Sallenmoore/foundryvtt-docker
that referenced
this pull request
Jun 18, 2023
This file is copied from cisagov/skeleton-ansible-role#85 and tweaked to pass pre-commit. See here for for a list of the elements that can exist in this file: https://ansible-lint.readthedocs.io/en/latest/configuring.html Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request:
ansible-lint(it was previously restricted to be<5)ansible-lintcisagovnamespace to the role metadata💭 Motivation and context
We have been avoiding version 5 of
ansible-lintfor a while because it introduced some breaking changes. The dust has now settled, and I have a way forward (thanks to @geerlingguy).Resolves #69.
🧪 Testing
All
pre-commithooks andmoleculetests pass.✅ Checklist