Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List as a requirement the Ansible role to be tested by Molecule #217

Closed
wants to merge 1 commit into from
Closed

List as a requirement the Ansible role to be tested by Molecule #217

wants to merge 1 commit into from

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Jan 28, 2025 •
edited
Loading

🗣 Description

This pull request:

  • Specifies the role to be tested by Molecule in requirements.yml.
  • Pins Molecule to 25.2.0 or later.

💭 Motivation and context

  • This is required as of Molecule 25.2.0.
  • This is a breaking change, so it will not work with earlier versions of Molecule.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

@jsf9k
List as a requirement the Ansible role to be tested by Molecule
00fa8b2 
This is required as of Molecule 25.2.0.  Also pin Molecule to 25.2.0
or greater since this is a breaking change.
@jsf9k jsf9k added bug This issue or pull request addresses broken functionality dependencies Pull requests that update a dependency file labels Jan 28, 2025
@jsf9k jsf9k self-assigned this Jan 28, 2025
@jsf9k jsf9k marked this pull request as ready for review January 28, 2025 16:09
@jsf9k jsf9k requested a review from a team January 28, 2025 16:09
@jsf9k jsf9k mentioned this pull request Jan 28, 2025
Closed
6 tasks
dav3r
dav3r approved these changes Jan 28, 2025
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

mcdonnnj
mcdonnnj reviewed Jan 28, 2025
View reviewed changes
molecule/default/requirements.yml
Comment on lines +10 to +11
- name: skeleton
src: https://github.com/cisagov/skeleton-ansible-role
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean for testing on branches?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You raise a very good point that I will have to think about.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #220 as an interim solution that I will pursue if I can't find a solution along the lines of this PR.

@jsf9k jsf9k mentioned this pull request Jan 28, 2025
Merged
@jsf9k
Copy link
Member Author

jsf9k commented Jan 30, 2025

Closed in favor of #221.

@jsf9k jsf9k closed this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcdonnnj mcdonnnj mcdonnnj left review comments

@dav3r dav3r dav3r approved these changes

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

Assignees

@jsf9k jsf9k

Labels
bug This issue or pull request addresses broken functionality dependencies Pull requests that update a dependency file
Projects
Skeleton Maintenance
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsf9k @dav3r @mcdonnnj @dv4harr10