Merge pull request #157 from cisagov/improvement/prefer-true-and-fals…

…e-to-yes-and-no-in-yaml Prefer true/false to yes/no in YAML files
cisagov · Sep 19, 2023 · 4d1ed57 · 4d1ed57
2 parents 26c6211 + 898a241
commit 4d1ed57
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 20 deletions.
diff --git a/README.md b/README.md
@@ -36,7 +36,7 @@ Here's how to use it in a playbook:
 
 ```yaml
 - hosts: all
-  become: yes
+  become: true
   become_method: sudo
   tasks:
     - name: Include skeleton

diff --git a/molecule/default/molecule-with-systemd.yml b/molecule/default/molecule-with-systemd.yml
@@ -15,80 +15,80 @@ platforms:
     image: geerlingguy/docker-amazonlinux2023-ansible:latest
     name: amazonlinux2023-systemd
     platform: amd64
-    pre_build_image: yes
-    privileged: yes
+    pre_build_image: true
+    privileged: true
     volumes:
       - /sys/fs/cgroup:/sys/fs/cgroup:rw
   - cgroupns_mode: host
     command: /lib/systemd/systemd
     image: geerlingguy/docker-debian10-ansible:latest
     name: debian10-systemd
     platform: amd64
-    pre_build_image: yes
-    privileged: yes
+    pre_build_image: true
+    privileged: true
     volumes:
       - /sys/fs/cgroup:/sys/fs/cgroup:rw
   - cgroupns_mode: host
     command: /lib/systemd/systemd
     image: geerlingguy/docker-debian11-ansible:latest
     name: debian11-systemd
     platform: amd64
-    pre_build_image: yes
-    privileged: yes
+    pre_build_image: true
+    privileged: true
     volumes:
       - /sys/fs/cgroup:/sys/fs/cgroup:rw
   - cgroupns_mode: host
     command: /lib/systemd/systemd
     image: cisagov/docker-debian12-ansible:latest
     name: debian12-systemd
     platform: amd64
-    pre_build_image: yes
-    privileged: yes
+    pre_build_image: true
+    privileged: true
     volumes:
       - /sys/fs/cgroup:/sys/fs/cgroup:rw
   - cgroupns_mode: host
     command: /lib/systemd/systemd
     image: cisagov/docker-kali-ansible:latest
     name: kali-systemd
     platform: amd64
-    pre_build_image: yes
-    privileged: yes
+    pre_build_image: true
+    privileged: true
     volumes:
       - /sys/fs/cgroup:/sys/fs/cgroup:rw
   - cgroupns_mode: host
     command: /lib/systemd/systemd
     image: geerlingguy/docker-fedora37-ansible:latest
     name: fedora37-systemd
     platform: amd64
-    pre_build_image: yes
-    privileged: yes
+    pre_build_image: true
+    privileged: true
     volumes:
       - /sys/fs/cgroup:/sys/fs/cgroup:rw
   - cgroupns_mode: host
     command: /lib/systemd/systemd
     image: geerlingguy/docker-fedora38-ansible:latest
     name: fedora38-systemd
     platform: amd64
-    pre_build_image: yes
-    privileged: yes
+    pre_build_image: true
+    privileged: true
     volumes:
       - /sys/fs/cgroup:/sys/fs/cgroup:rw
   - cgroupns_mode: host
     command: /lib/systemd/systemd
     image: geerlingguy/docker-ubuntu2004-ansible:latest
     name: ubuntu-20-systemd
     platform: amd64
-    pre_build_image: yes
-    privileged: yes
+    pre_build_image: true
+    privileged: true
     volumes:
       - /sys/fs/cgroup:/sys/fs/cgroup:rw
   - cgroupns_mode: host
     command: /lib/systemd/systemd
     image: geerlingguy/docker-ubuntu2204-ansible:latest
     name: ubuntu-22-systemd
     platform: amd64
-    pre_build_image: yes
-    privileged: yes
+    pre_build_image: true
+    privileged: true
     volumes:
       - /sys/fs/cgroup:/sys/fs/cgroup:rw
 scenario:

diff --git a/molecule/default/upgrade.yml b/molecule/default/upgrade.yml
@@ -1,7 +1,7 @@
 ---
 - hosts: all
   name: Upgrade base image
-  become: yes
+  become: true
   become_method: ansible.builtin.sudo
   tasks:
     - name: Upgrade system packages