[HOLD] Migrate portscan and vulnscan Instances to Debian Buster #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Packer configurations for nessus and nmap to build from Debian Buster base AMIs.
6 tasks
mcdonnnj
requested review from
dav3r,
felddy,
hillaryj,
jsf9k and
a team
as code owners
Missed updating these from Debian Stretch to Debian Buster to reflect the rest of this PR's changes.
…o scanners_on_buster
dav3r
approved these changes
Nov 12, 2020
jsf9k
approved these changes
Nov 13, 2020
With the vulnscanner instances moving to Python 3 only, the script that installs the Nessus base policy needs to be updated for Python 3.
jsf9k
reviewed
Nov 16, 2020
Switch .format() calls for f-strings since this script will run on systems with Python 3.6+. Co-authored-by: Shane Frasier <jeremy.frasier@trio.dhs.gov>
Change two other str.format() uses to f-strings to mirror the changes suggested in the PR review by @jsf9k.
Call the correct Python binary and update nessus_base.py to mirror how it is used.
hillaryj
changed the title
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR updates the Packer configurations to build the
portscanandvulnscanAMIs (nessus.jsonandnmap.json) on Debian Buster.This PR should only be merged along with the following PRs:
cisagov/cyhy-runner#2
https://github.com/jsf9k/cyhy-commander/pull/17
💭 Motivation and Context
Migrating cisagov/cyhy-runner to Python 3 requires the instances it runs on to update to using Debian Buster.
🧪 Testing
I have used these updates to create AMIs that were deployed as part of testing the linked PRs.
✅ Checklist