Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/cyhy archive enhancements #7

Merged
merged 3 commits into from
Sep 15, 2018
Merged

Improvement/cyhy archive enhancements #7

merged 3 commits into from
Sep 15, 2018

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented Sep 14, 2018

No description provided.

@dav3r
Modify cyhy-archive to require a command-line argument for the direct…
be36d00 
…ory to save the archive files to
@dav3r
Add cyhy_archive.sh, a script that can be used by cron to call cyhy-a…
213023c 
…rchive, copy the archives to a permanent storage location (e.g. AWS S3), then delete the local archive files
@dav3r dav3r self-assigned this Sep 14, 2018
@dav3r dav3r requested review from felddy, jsf9k and KyleEvers September 14, 2018 20:49
jsf9k
jsf9k approved these changes Sep 15, 2018
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, although I'd like to see the python imports organized into these three groups:

  1. Built-in imports
  2. 3rd party imports
  3. Local imports

The imports should be sorted alphabetically within each group.

@dav3r dav3r merged commit 0a9f95c into develop Sep 15, 2018
@dav3r dav3r deleted the improvement/cyhy_archive_enhancements branch September 15, 2018 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@KyleEvers KyleEvers Awaiting requested review from KyleEvers

Assignees

@dav3r dav3r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dav3r @jsf9k