Add logging to the cyhy-nvdsync and cyhy-kevsync scripts #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsf9k
added
the
improvement
jsf9k
added a commit
to cisagov/cyhy_amis
that referenced
this pull request
Apr 7, 2022
…gov/cyhy-core#67 By logging a message for any uncaught exceptions, we are able to trigger AWS CloudWatch metric alarms via the code in terraform/nvdsync_failure_alarms.tf and terraform/kevsync_failure_alarms.tf whenever the cyhy-nvdsync or cyhy-kevsync scripts fails.
By logging a message for any uncaught exceptions, we are able to trigger AWS CloudWatch metric alarms via the code in terraform/nvdsync_failure_alarms.tf and terraform/kevsync_failure_alarms.tf of cisagov/cyhy_amis.
jsf9k
force-pushed
the
improvement/tweak-error-messages-for-notifications
branch
from
e1bb053 to
4f7e4e6
Compare
This was referenced Apr 7, 2022
jsf9k
added a commit
to cisagov/cyhy_amis
that referenced
this pull request
Apr 7, 2022
…gov/cyhy-core#67 By logging a message for any uncaught exceptions, we are able to trigger AWS CloudWatch metric alarms via the code in terraform/nvdsync_failure_alarms.tf and terraform/kevsync_failure_alarms.tf whenever the cyhy-nvdsync or cyhy-kevsync scripts fails.
jsf9k
added a commit
to cisagov/cyhy_amis
that referenced
this pull request
Apr 7, 2022
…gov/cyhy-core#67 By logging a message for any uncaught exceptions, we are able to trigger AWS CloudWatch metric alarms via the code in terraform/nvdsync_failure_alarms.tf and terraform/kevsync_failure_alarms.tf whenever the cyhy-nvdsync or cyhy-kevsync scripts fails.
jsf9k
added a commit
to cisagov/cyhy_amis
that referenced
this pull request
Apr 20, 2022
…gov/cyhy-core#67 By logging a message for any uncaught exceptions, we are able to trigger AWS CloudWatch metric alarms via the code in terraform/nvdsync_failure_alarms.tf and terraform/kevsync_failure_alarms.tf whenever the cyhy-nvdsync or cyhy-kevsync scripts fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull request adds standard Python logging to the
cyhy-nvdsyncandcyhy-kevsyncscripts, particularly for uncaught exceptions.💭 Motivation and context
By logging a message for any uncaught exceptions, we are able to trigger AWS CloudWatch metric alarms via the code in
terraform/nvdsync_failure_alarms.tfandterraform/kevsync_failure_alarms.tfof cisagov/cyhy_amis#394 whenever either of these scripts fails.Contributes to the resolution of cisagov/cyhy-system#37. See also:
🧪 Testing
I ran each scripts locally and verified that the expected log message was emitted upon failure.
✅ Pre-approval checklist