Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CVE feed URL #51

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Update CVE feed URL #51

merged 1 commit into from
Oct 14, 2020

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented Oct 14, 2020

🗣 Description

This PR updates the URL pattern that we use to fetch CVE data from the National Vulnerability Database (NVD).

💭 Motivation and Context

The old 1.0 URL that we were using is no longer valid, so we must update to 1.1 if we want to get any CVE data.

🧪 Testing

I made this change manually and ran it successfully, confirming that it works as expected.

📷 Screenshots (if appropriate)

🚥 Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (causes existing functionality to change)

✅ Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dav3r
Update CVE feed URL
d9c7809 
The old 1.0 URL is no longer valid, so we must update to 1.1.
@dav3r dav3r added the bugfix label Oct 14, 2020
@dav3r dav3r self-assigned this Oct 14, 2020
jsf9k
jsf9k approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small but powerful change.

mcdonnnj
mcdonnnj approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for digging into this!

@dav3r dav3r merged commit 569ced6 into develop Oct 14, 2020
@dav3r dav3r deleted the bugfix/update_cve_feed_url branch October 14, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsf9k jsf9k jsf9k approved these changes

@mcdonnnj mcdonnnj mcdonnnj approved these changes

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@hillaryj hillaryj Awaiting requested review from hillaryj

Assignees

@dav3r dav3r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dav3r @jsf9k @mcdonnnj