-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to check a single IP's geolocation data. #32
Conversation
…he GeoIP2 database that is currently on the server.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've got a couple of small changes to request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellente! 🌶
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requested a minor change in the interest of DRYness. Also have a minor question about language.
@mcdonnnj, feel free to make the Snyk check optional so you can merge this in. Snyk has a cap on closed source projects I guess. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
This PR adds a new switch to the cyhy-geoip tool that allows it to check a given IP address's geolocation in the CyHy database against what's in the GeoIP2 database on the server.