Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to check a single IP's geolocation data. #32

Merged
merged 3 commits into from
Aug 2, 2019

Conversation

mcdonnnj
Copy link
Member

@mcdonnnj mcdonnnj commented Aug 2, 2019

This PR adds a new switch to the cyhy-geoip tool that allows it to check a given IP address's geolocation in the CyHy database against what's in the GeoIP2 database on the server.

…he GeoIP2 database that is currently on the server.
@mcdonnnj mcdonnnj requested review from felddy, jsf9k and dav3r August 2, 2019 10:20
@mcdonnnj mcdonnnj self-assigned this Aug 2, 2019
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got a couple of small changes to request.

@mcdonnnj mcdonnnj requested a review from dav3r August 2, 2019 13:35
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellente! 🌶

Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a minor change in the interest of DRYness. Also have a minor question about language.

@mcdonnnj mcdonnnj requested a review from jsf9k August 2, 2019 15:17
@jsf9k
Copy link
Member

jsf9k commented Aug 2, 2019

@mcdonnnj, feel free to make the Snyk check optional so you can merge this in. Snyk has a cap on closed source projects I guess.

@mcdonnnj mcdonnnj requested a review from dav3r August 2, 2019 17:26
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@mcdonnnj mcdonnnj merged commit 59aa234 into develop Aug 2, 2019
@mcdonnnj mcdonnnj deleted the add_geoip_check branch August 2, 2019 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants