Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve issue 20 #22

Merged
merged 6 commits into from
Jun 25, 2019
Merged

Resolve issue 20 #22

merged 6 commits into from
Jun 25, 2019

Conversation

mcdonnnj
Copy link
Member

This updates the files being pulled per #20 and does a little code cleanup to align it more with current development practices.

@mcdonnnj mcdonnnj requested review from felddy, jsf9k and dav3r June 24, 2019 21:38
@mcdonnnj mcdonnnj self-assigned this Jun 24, 2019
dav3r
dav3r approved these changes Jun 24, 2019
View reviewed changes
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me after you make one minor change to the usage output.

jsf9k
jsf9k approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Nice work!

var/load_places.sh

function usage() {
echo "Usage: ${0##*/} [database_section]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm digging the shell fu!

felddy
felddy approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rare and coveted triple approval. ✅✅✅

@mcdonnnj mcdonnnj merged commit d2efabf into develop Jun 25, 2019
@mcdonnnj mcdonnnj deleted the resolve_issue_20 branch July 3, 2019 13:07
@mcdonnnj mcdonnnj mentioned this pull request Jul 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felddy felddy felddy approved these changes

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r dav3r approved these changes

Assignees

@mcdonnnj mcdonnnj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcdonnnj @felddy @jsf9k @dav3r