Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement/cyhy nvdsync use json feed #15

Merged
merged 4 commits into from
Feb 12, 2019
Merged

Improvement/cyhy nvdsync use json feed #15

merged 4 commits into from
Feb 12, 2019

Conversation

dav3r
Copy link
Member

@dav3r dav3r commented Feb 12, 2019

This PR switches from pulling CVE data via the soon-to-be-deprecated NVD XML feed to the current standard JSON feed. See issue #13 for details.

@dav3r dav3r self-assigned this Feb 12, 2019
@dav3r dav3r requested review from felddy, jsf9k and KyleEvers February 12, 2019 15:19
felddy
felddy approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@felddy felddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh XML, you weren't easy to parse, but you did guarantee some semblance of integrity if I bothered to use a schema to validate you. Ooh, JSON!

Looks good.

jsf9k
jsf9k approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@jsf9k jsf9k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I especially appreciate your placation of flake8.
🎱

@dav3r dav3r merged commit 396c952 into develop Feb 12, 2019
@dav3r dav3r deleted the improvement/cyhy_nvdsync_use_json_feed branch February 12, 2019 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felddy felddy felddy approved these changes

@jsf9k jsf9k jsf9k approved these changes

@KyleEvers KyleEvers Awaiting requested review from KyleEvers

Assignees

@dav3r dav3r

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dav3r @felddy @jsf9k