Pin the Dependencies Used #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a version pin for the certbot/dns-route53 image using the latest released version.
This adds a version pin for the `python3` package installed as well as adding the `--no-cache` option to reduce the size of generated images.
Pin the version of `pip` that is installed in the image. Replace the `--upgrade` flag with the `--no-cache-dir` flag since we are installing a specific version and to reduce the size of the resulting image.
Add the `setuptools` and `wheel` packages at pinned versions to the Docker image. These are common installs for our Python projects and we should ensure they are pinned to specific versions.
Add version pinning for the remaining Python packages, break their installation into its own step, and switch the `--upgrade` flag for the `--no-cache-dir` flag.
mcdonnnj
added
improvement
jsf9k
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This PR pins the dependencies used for this Docker image. This includes the Docker image it is built on as well as the Python packages it needs to function. In addition installation of packages was configured to perform no caching.
💭 Motivation and context
Creating repeatable Docker image builds is a good strategy to ensure you are not blindsided by changes. This resolves #26 toward that end. The caching changes also shaved a whole 11MiB off the generated size (that's a savings of 3.5%!).
🧪 Testing
Automated tests pass and I was able to build an image successfully using this configuration.
✅ Checklist