Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update role vars and role variable description #59

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Mar 21, 2024

🗣 Description

This pull request updates role variables and a role variable description:

  • Edit README.md to make it clear what platforms still support Python 2.
  • Ensure that all platforms install the correct packages, and can be expected to continue to do so as new platforms are released.

💭 Motivation and context

I realized that the role variable description in this role needed to be updated when working on cisagov/ansible-role-pip#61. While I was here I figured I would do some housekeeping.

Resolves #50.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.

- Edit README.md to make it clear what platforms still support Python
2.
- Ensure that all platforms install the correct packages, and can be
expected to continue to do so as new platforms are released.
@jsf9k jsf9k added the improvement This issue or pull request will add or improve functionality, maintainability, or ease of use label Mar 21, 2024
@jsf9k jsf9k self-assigned this Mar 21, 2024
@jsf9k jsf9k marked this pull request as ready for review March 21, 2024 20:02
@jsf9k jsf9k requested a review from a team March 21, 2024 20:02
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

Copy link
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔ One request for your consideration.

vars/Debian.yml Show resolved Hide resolved
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
@jsf9k jsf9k merged commit 01f660e into develop Mar 22, 2024
14 checks passed
@jsf9k jsf9k deleted the documentation/remove-unsupported-platforms branch March 22, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement This issue or pull request will add or improve functionality, maintainability, or ease of use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update role for removal of Python 2 from Debian
4 participants