Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the role for changes in cisagov/ansible-role-cyhy-core #56

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Update the role for changes in cisagov/ansible-role-cyhy-core #56

merged 2 commits into from
Jul 10, 2024

Conversation

mcdonnnj
Copy link
Member

🗣 Description

This pull request makes updates to the role to provide necessary interoperability with changes in the cisagov/ansible-role-cyhy-core dependency.

💭 Motivation and context

This is a sibling pull request to cisagov/ansible-role-cyhy-core#79 to ensure we can pass necessary arguments to the downstream cisagov/ansible-role-geoip2 dependency.

🧪 Testing

Automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated
    to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

mcdonnnj added 2 commits July 10, 2024 15:21
@mcdonnnj
Update for cisagov/ansible-role-cyhy-core changes
2490979 
Add new variables to pass through to cisagov/ansible-role-cyhy-core
that reflect updated functionality and features due to changes in the
cisagov/ansible-role-geoip2 role.
@mcdonnnj
Escape underscores in role variable names
6a867dc 
This ensures that when the Markdown is interpreted there is no
unexpected styling.
@mcdonnnj mcdonnnj added breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use terraform Pull requests that update Terraform code test This issue or pull request adds or otherwise modifies test code labels Jul 10, 2024
@mcdonnnj mcdonnnj requested a review from a team July 10, 2024 20:18
@mcdonnnj mcdonnnj self-assigned this Jul 10, 2024
@mcdonnnj mcdonnnj enabled auto-merge July 10, 2024 20:18
@mcdonnnj mcdonnnj merged commit f5bf2e4 into develop Jul 10, 2024
13 checks passed
@mcdonnnj mcdonnnj deleted the improvement/update_usage_of_ansible-role-cyhy-core branch July 10, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dv4harr10 dv4harr10 dv4harr10 approved these changes

@jsf9k jsf9k jsf9k approved these changes

@dav3r dav3r Awaiting requested review from dav3r dav3r is a code owner

@felddy felddy Awaiting requested review from felddy felddy is a code owner

@jasonodoom jasonodoom Awaiting requested review from jasonodoom

Assignees

@mcdonnnj mcdonnnj

Labels
breaking change This issue or pull request involves changes to existing functionality improvement This issue or pull request will add or improve functionality, maintainability, or ease of use terraform Pull requests that update Terraform code test This issue or pull request adds or otherwise modifies test code
Projects
CyHy System
Status: Done
Cyber Hygiene (CyHy)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcdonnnj @jsf9k @dv4harr10