Add support for the dnf5 package manager
#38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OS is a secondary factor when determining which vars or tasks files to use.
Note that the tasks file is just a symlink to the dnf tasks file.
jsf9k
added
the
improvement
jsf9k
added a commit
to cisagov/freeipa-server-packer
that referenced
this pull request
Nov 12, 2024
…d-security-updates This is being done for testing purposes and this change can be reverted once cisagov/ansible-role-automated-security-updates#38 is merged.
jsf9k
force-pushed
the
improvement/support-dnf5
branch
2 times, most recently
from
8116621 to
ca17d56
Compare
With these updates the /etc/dnf/automatic.conf file will be created if it does not exist, as seems to be the case. These changes also take advantage of the INI structure of /etc/dnf/automatic.conf to use community.general.ini_file vice ansible.builtin.lineinfile. This makes the code cleaner, less fragile, and easier to understand.
jsf9k
force-pushed
the
improvement/support-dnf5
branch
from
ca17d56 to
ee888ce
Compare
We don't support this platform yet, but we will soon. See cisagov/skeleton-ansible-role#207 for more details.
14 tasks
mcdonnnj
approved these changes
Nov 13, 2024
dv4harr10
approved these changes
Nov 13, 2024
Co-authored-by: Nick M <50747025+mcdonnnj@users.noreply.github.com>
We don't use these right now, but we may in the future. Co-authored-by: Nick M <50747025+mcdonnnj@users.noreply.github.com>
jsf9k
force-pushed
the
improvement/support-dnf5
branch
from
d839ff9 to
c0476df
Compare
jsf9k
added a commit
to cisagov/freeipa-server-packer
that referenced
this pull request
Nov 13, 2024
…security-updates We can do this now that cisagov/ansible-role-automated-security-updates#38 has been merged.
jsf9k
added a commit
that referenced
this pull request
Nov 27, 2024
I had previously attempted to preemptively prepare the Molecule test code for the addition of Fedora 41 in #38, but I failed to realize that the Fedora version is stored in host.system_info.release not host.system_info.codename. In fact, host.system_info.codename is actually an empty string for Fedora.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗣 Description
This pull requests adds support for the
dnf5package manager.💭 Motivation and context
We are adding support for Fedora 41 soon in cisagov/skeleton-ansible-role#207, and
ansibleidentifies the package manager for that platform asdnf5, so we need to support it.🧪 Testing
All automated tests pass. These changes are also tested as part of cisagov/skeleton-ansible-role#207.
✅ Pre-approval checklist