Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove collections from meta/requirements.yml #46

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

jsf9k
Copy link
Member

@jsf9k jsf9k commented Nov 1, 2023

🗣 Description

This pull request removes any collections from meta/requirements.yml.

💭 Motivation and context

ansible-galaxy does not appear to allow collections to appear in the meta/requirements.yml file. See here for more details.

See also cisagov/skeleton-ansible-role#165.

🧪 Testing

All automated tests pass.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • All relevant type-of-change labels have been added.
  • I have read the CONTRIBUTING document.
  • These code changes follow cisagov code standards.
  • All new and existing tests pass.

ansible-galaxy does not appear to allow them there.  See here for more
details:
cisagov/skeleton-ansible-role#153 (comment)
@jsf9k jsf9k self-assigned this Nov 1, 2023
@jsf9k jsf9k added the bug This issue or pull request addresses broken functionality label Nov 1, 2023
@jsf9k jsf9k marked this pull request as ready for review November 1, 2023 19:00
@jsf9k jsf9k enabled auto-merge November 1, 2023 19:00
@jsf9k jsf9k requested a review from a team November 1, 2023 19:00
Copy link
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jsf9k jsf9k merged commit 55de5ee into develop Nov 1, 2023
10 checks passed
@jsf9k jsf9k deleted the bugfix/remove-collections-from-meta branch November 1, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants