Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lineage pull request for: skeleton #7

Merged
merged 20 commits into from
Feb 24, 2023
Merged

Lineage pull request for: skeleton #7

merged 20 commits into from
Feb 24, 2023

Conversation

cisagovbot
Copy link

Lineage Pull Request

Lineage has created this pull request to incorporate new changes found in an
upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-docker.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with
your project.


Note: You are seeing this because one of this repository's maintainers has
configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

mcdonnnj and others added 20 commits January 31, 2023 13:06
Update pre-commit hooks using `pre-commit autoupdate`. The `ansible-lint` hook
is intentionally held back to be updated independently to v6.
Lineage pull request for: skeleton
When Dependabot creates a PR it requires this permission in order to
push Docker images to ghcr.io.
Co-authored-by: Nick <50747025+mcdonnnj@users.noreply.github.com>
Update wheel along with pip and setuptools
In this case it doesn't matter because we are starting from a
Python3-specific base container, but other projects that use this
skeleton may not be.  Specifying pip3 ensures that the Python 2
version of pip is not called by mistake.
Specify the default group to run under in the Dockerfile
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 3 to 4.
- [Release notes](https://github.com/docker/build-push-action/releases)
- [Commits](docker/build-push-action@v3...v4)

---
updated-dependencies:
- dependency-name: docker/build-push-action
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…/build-push-action-4

Bump docker/build-push-action from 3 to 4
Specify pip3 in the file where it got blown away by a rebase
@cisagovbot cisagovbot added the upstream update This issue or pull request pulls in upstream updates label Feb 24, 2023
@dav3r dav3r assigned jmorrowomni and unassigned felddy, jsf9k, dav3r and mcdonnnj Feb 24, 2023
@dav3r dav3r mentioned this pull request Feb 24, 2023
12 tasks
@dav3r
Copy link
Member

dav3r commented Feb 24, 2023

FYI, I just made the Docker username/password secrets available to this repo and I'm going to re-run the failed test.

@dav3r dav3r assigned dav3r and unassigned jmorrowomni Feb 24, 2023
@dav3r
Copy link
Member

dav3r commented Feb 24, 2023

Since this repo has not yet had its first-commits PR (#5) merged, the Docker image name is still example and that is causing the build failure here. Furthermore, since #5 needs the pre-commit updates in this PR, I'm going ahead and merging this PR (despite that build failure) so progress can continue on #5.

@dav3r dav3r merged commit 221f244 into develop Feb 24, 2023
@dav3r dav3r deleted the lineage/skeleton branch February 24, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upstream update This issue or pull request pulls in upstream updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants