Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install kind (and pre-pull the latest node image), Chrome and ChromeDriver #20

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Install kind (and pre-pull the latest node image), Chrome and ChromeDriver #20

merged 3 commits into from
Feb 28, 2024

Conversation

edigaryev
Copy link
Collaborator

kind hardcodes the image in its releases, so our pre-pull shouldn't go to waste.

Resolves #18, resolves #19.

@edigaryev edigaryev requested a review from fkorotkov February 27, 2024 09:15
@fkorotkov
Copy link
Contributor

Will be interesting to see how which of the both changes affect disk size as I mentioned in #19. #21 should help with that.

@edigaryev
Copy link
Collaborator Author

Will be interesting to see how which of the both changes affect disk size as I mentioned in #19. #21 should help with that.

Rebased, it seems that the difference is 0.994 GB for arm64 (including Chrome and ChromeDriver).

@fkorotkov
Copy link
Contributor

Could you please check kind impact of it? It seems kindest:node images are around 400Mb and I'm still not sure if people use the "latest" version or pin it. In case of pinning our pre-pulling will not work as efficient and will just accumulate garbage.

I guess we can start by pre-installing kind but not pre-pulling things and then based on feedback add optimization.

@edigaryev
Copy link
Collaborator Author

edigaryev commented Feb 28, 2024 •
edited
Loading

Could you please check kind impact of it?

11.180 GB (https://cirrus-ci.com/task/5359690658349056?logs=info#L2) - 10.200 GB (https://cirrus-ci.com/task/5058246633848832?logs=info#L2) = 0.98 GB

@fkorotkov
Copy link
Contributor

Let's skip the cluster creation then. What about Chrome on arm64 though? Why only x86?

@edigaryev
Copy link
Collaborator Author

Let's skip the cluster creation then.

See 0f78b9d.

What about Chrome on arm64 though? Why only x86?

It's not available yet: GoogleChromeLabs/chrome-for-testing#1.

@edigaryev edigaryev enabled auto-merge (squash) February 28, 2024 15:12
@edigaryev edigaryev merged commit 21cf6aa into main Feb 28, 2024
2 of 5 checks passed
@edigaryev edigaryev deleted the kind-and-chrome branch February 28, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkorotkov fkorotkov fkorotkov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pre-install kind Pre-install Chrome
2 participants
@edigaryev @fkorotkov