Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten supervisord.conf example by using the defaults #982

Merged
merged 1 commit into from
May 27, 2016
Merged

Shorten supervisord.conf example by using the defaults #982

merged 1 commit into from
May 27, 2016

Conversation

mnaberez
Copy link
Contributor

@mnaberez mnaberez commented May 27, 2016

  • autostart=true can be removed because it is the default.
  • autorestart=true can also be removed. The default value of autorestart=unexpected is better because the Circus page says the process should be "restarted in case it crashes". autorestart=true would restart unconditionally, including if the process exited with status 0 (success). The default value of autorestart=unexpected will restart the process if it crashes.

@k4nar
Copy link
Contributor

k4nar commented May 27, 2016

Hi @mnaberez :) . Thanks for your great work on Supervisor!

Nice catch, if those are the defaults value in the latest version of Supervisor they shouldn't be in our example.

@k4nar k4nar merged commit 315517b into circus-tent:master May 27, 2016
@mnaberez
Copy link
Contributor Author

Nice catch, if those are the defaults value in the latest version of Supervisor they shouldn't be in our example.

Thanks for merging. Yes, autostart=true and autorestart=unexpected are the defaults in any semi-modern version of Supervisor (since 3.0a11 at least, which was released in December 2011).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants