Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not allow adding watchers with the same lowercase names #1117

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

biozz
Copy link
Contributor

@biozz biozz commented Mar 1, 2020

  • add conversion to lowercase when checking for existing watcher
  • add test with two watchers foo and Foo, which should raise

Fixes #936

@coveralls
Copy link

coveralls commented Mar 1, 2020

Coverage Status

Coverage remained the same at 62.97% when pulling 74f4c72 on biozz:same-lowercase-name-watchers into 8172166 on circus-tent:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 12df448 on biozz:same-lowercase-name-watchers into 95905cf on circus-tent:master.

@k4nar
Copy link
Contributor

k4nar commented Mar 2, 2020

👍

Could you rebase on master to fix the py34 build?

@biozz
Copy link
Contributor Author

biozz commented Mar 2, 2020

OMG I screwed up this rebase hard... Will try to fix.

@k4nar
Copy link
Contributor

k4nar commented Mar 2, 2020

At a glance, I would say that your fork's master was not up-to-date with the upstream :) .

@biozz biozz force-pushed the same-lowercase-name-watchers branch from b303c2e to 5e13af8 Compare March 2, 2020 18:27

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
- add conversion to lowercase when checking for existing watcher
- add test with two watchers foo and Foo, which should raise

Fixes circus-tent#936
@biozz biozz force-pushed the same-lowercase-name-watchers branch from 5e13af8 to 74f4c72 Compare March 2, 2020 18:28
@biozz
Copy link
Contributor Author

biozz commented Mar 10, 2020

@k4nar, I managed to fix it, could you please review it?

@k4nar k4nar merged commit c751d0f into circus-tent:master Mar 10, 2020
@biozz biozz added this to the 0.17 milestone Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More problems with watchers when mixing upper and lower cases
3 participants