Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the pyzmq dependency #1111

Merged
merged 2 commits into from
Dec 11, 2019
Merged

Update the pyzmq dependency #1111

merged 2 commits into from
Dec 11, 2019

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented Dec 10, 2019 •
edited
Loading

Fixes #1099

Update the dependency requirement pyzmq>=17 and update the code
to adapt to corresponding API changes.

@k4nar This is blocked by PR #1110 that I opened that first fixes the CI on Travis.
I hope this PR will breath back some life into circus. I intend to look into porting the
code to tornado>5 in the near future, but this is more complicated. Any help or
directions there would be very welcome.

@coveralls
Copy link

coveralls commented Dec 10, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 62.97% when pulling 51bb088 on sphuber:fix_1099_update_pyzmq into 86177a1 on circus-tent:master.

This was referenced Dec 10, 2019
Closed
Merged
@sphuber
Update dependency requirement pyzmq>=17
1968798 
Some imports in `circus.tests.support` have been deprecated and moved.
They are no longer needed as the ZMQ pollers now work out of the box
with tornado io loops.
@sphuber
Remove zmq ioloop with that one of tornado
51bb088 
As of `pyzmq>=17.0.0` the default tornado ioloop is compatible.
@sphuber sphuber force-pushed the fix_1099_update_pyzmq branch from 3cc126e to 51bb088 Compare December 11, 2019 17:02
@sphuber sphuber changed the title [BLOCKED] Update the pyzmq dependency Update the pyzmq dependency Dec 11, 2019
k4nar
k4nar approved these changes Dec 11, 2019
View reviewed changes
Copy link
Contributor

@k4nar k4nar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@k4nar k4nar merged commit b3a0647 into circus-tent:master Dec 11, 2019
@sphuber sphuber deleted the fix_1099_update_pyzmq branch December 11, 2019 22:39
@sphuber sphuber mentioned this pull request Dec 16, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k4nar k4nar k4nar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Circus forcing PyZMQ <17.0
3 participants
@sphuber @coveralls @k4nar