Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation & tests for finding a hook using pythonpath #1013

Merged
merged 5 commits into from
Oct 31, 2016

Conversation

pconerly
Copy link
Contributor

Documentation and a test for finding a hook using env.pythonpath

Resolves #867
FYI @k4nar

@pconerly pconerly force-pushed the find-relative-hook-docs branch from 1155cbb to b8c96b0 Compare October 25, 2016 22:27
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 62.737% when pulling ef3bfb3 on pconerly:find-relative-hook-docs into 23c0408 on circus-tent:master.

@pconerly pconerly closed this Oct 31, 2016
@pconerly pconerly reopened this Oct 31, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 62.836% when pulling 4c79b44 on pconerly:find-relative-hook-docs into 23c0408 on circus-tent:master.

@pconerly pconerly closed this Oct 31, 2016
@pconerly pconerly reopened this Oct 31, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 62.786% when pulling 4c79b44 on pconerly:find-relative-hook-docs into 23c0408 on circus-tent:master.

hooks.before_start = hooks.my_hook.hook

[env:foo]
PYTHONPATH = $PWD/circus/tests/config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in this example we should use PYTHONPATH=$PYTHONPATH:$PWD instead

[env:foo]
PYTHONPATH = $PWD/circus/tests/config

You can use bash commands like *$PWD* in the *PYTHONPATH*.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/bash commands/env variables/ :) .

@k4nar
Copy link
Contributor

k4nar commented Oct 31, 2016

Thanks! I've made a few comments, but otherwise it's really great to have an exemple in the docs.

@@ -100,9 +100,9 @@ PYTHONPATH in *[env:watchername]*.
hooks.before_start = hooks.my_hook.hook

[env:foo]
PYTHONPATH = $PWD/circus/tests/config
PYTHONPATH = $PYTHONPATH:$PWD/circus/tests/config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should have circus/tests/config in the doc. This is only relevant in our tests.

@pconerly pconerly force-pushed the find-relative-hook-docs branch from 35e4586 to 1de0834 Compare October 31, 2016 16:56
@coveralls
Copy link

Coverage Status

Coverage increased (+0.05%) to 62.77% when pulling 35e4586 on pconerly:find-relative-hook-docs into 23c0408 on circus-tent:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.07%) to 62.786% when pulling 1de0834 on pconerly:find-relative-hook-docs into 23c0408 on circus-tent:master.

@pconerly
Copy link
Contributor Author

I amended the commit to remove the circus/tests/config

On Oct 31, 2016 10:03 AM, "Coveralls" notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/8589993

Coverage increased (+0.07%) to 62.786% when pulling 1de0834
1de0834
on pconerly:find-relative-hook-docs
into 23c0408
23c0408
on circus-tent:master
.


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#1013 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcrMNRd6WkjBFJl9UBYKColNWMQa3c8ks5q5h9KgaJpZM4Kgjm5
.

Copy link
Contributor

@k4nar k4nar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect thanks!

@k4nar k4nar merged commit 1286234 into circus-tent:master Oct 31, 2016
@pconerly pconerly deleted the find-relative-hook-docs branch October 31, 2016 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants