-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation & tests for finding a hook using pythonpath #1013
Conversation
1155cbb
to
b8c96b0
Compare
hooks.before_start = hooks.my_hook.hook | ||
|
||
[env:foo] | ||
PYTHONPATH = $PWD/circus/tests/config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think in this example we should use PYTHONPATH=$PYTHONPATH:$PWD
instead
[env:foo] | ||
PYTHONPATH = $PWD/circus/tests/config | ||
|
||
You can use bash commands like *$PWD* in the *PYTHONPATH*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/bash commands/env variables/ :) .
Thanks! I've made a few comments, but otherwise it's really great to have an exemple in the docs. |
@@ -100,9 +100,9 @@ PYTHONPATH in *[env:watchername]*. | |||
hooks.before_start = hooks.my_hook.hook | |||
|
|||
[env:foo] | |||
PYTHONPATH = $PWD/circus/tests/config | |||
PYTHONPATH = $PYTHONPATH:$PWD/circus/tests/config |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should have circus/tests/config
in the doc. This is only relevant in our tests.
35e4586
to
1de0834
Compare
I amended the commit to remove the circus/tests/config On Oct 31, 2016 10:03 AM, "Coveralls" notifications@github.com wrote:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect thanks!
Documentation and a test for finding a hook using
env.pythonpath
Resolves #867
FYI @k4nar