-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to data.xml v0.2.0-alpha5 #23
base: master
Are you sure you want to change the base?
Conversation
Since this is backward-incompatible with the previous data.xml, I'm not sure what the right thing to do is here. We needed to run with the newer, alpha-release of data.xml since that's what we have in our codebase, so we deployed our own version of this branch. |
Thanks for the PR! Would you mind undoing the I am hesitant to switch to an alpha release of data.xml since that forces consumers of circleci.test to switch as well. I would like to wait until the new API for data.xml is declared stable before I could consider forcing that change on others. My current suspicion is that the correct approach is to switch to javax.xml for XML processing and drop the clojure.data.xml dependency altogether. |
Minimal changes to support data.xml 0.2.0-alpha5 release. This is backwards incompatible with data.xml previous to 0.2.0.
I updated the code to do only the minimal changes required to support data.xml 0.2.0-alpha. I'm note sure either what's the best strategy wrt versions. Possibly an alpha release would work. |
Includes configuration to test that reporter works with current stable and latest data.xml
@gordonsyme I just added a commit that removes the hard dependency on data.xml alpha versions, and some tests to show that this works on both the stable and alpha versions, so it's usable by everybody on at least current stable and latest alpha. |
Lazy dev question 😉 Does this make it ClojureScript compatible? Sorry for the noise: checked the code and it is Clojure only for now. |
Necessary changes to support alpha version of clojure.data.xml, which
supports clojurescript and xml namespaces.