Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ${{matrix.java}} from codecov flags #6

Merged
merged 1 commit into from
Feb 6, 2023

Conversation

fthomas
Copy link
Contributor

@fthomas fthomas commented Feb 6, 2023

That variable prevents the coverage report from being uploaded if it
contains an @, see: circe/circe-config#361 (comment)

That variable prevents the coverage report from being uploaded if it
contains an `@`, see: circe/circe-config#361 (comment)
Copy link
Collaborator

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it's not really relevant for coverage anyway :)

@armanbilge armanbilge merged commit 6335285 into circe:main Feb 6, 2023
@fthomas fthomas deleted the topic/rm-matrix-java-flag branch February 6, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants