Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Jackson 2.11 and 2.12 #236

Merged
merged 2 commits into from
Dec 15, 2020

Conversation

etspaceman
Copy link
Contributor

No description provided.

.settings(
moduleName := "circe-jackson211",
libraryDependencies ++= jacksonDependencies("2.11.4"),
unmanagedSourceDirectories in Compile += (baseDirectory in ThisBuild).value / "210"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both 2.11 and 2.12 can use the 2.10 setup

@travisbrown
Copy link
Member

Thanks! This looks good to me, but can you also go ahead and aggregate the new modules in root?

@etspaceman
Copy link
Contributor Author

Done!

@travisbrown travisbrown merged commit 013fa63 into circe:master Dec 15, 2020
@etspaceman etspaceman deleted the jackson11and12 branch December 15, 2020 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants