-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Oversampling Feature #84
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
d537b8d tests failed because of some import errors with pennylane lightning |
majafranz
approved these changes
Feb 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good work! LGTM.
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
…ssentials into coefficients-calculation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces oversampling for the frequency and time domain.
It also allows applying fftshift to get a properly ordered spectrogram.
With this implementation we move away from the pennylane reference (as the api is too limited).
However, we still have a test in place, to ensure that nothing is faulty with our implementation.
As the method now returns coefficients and frequencies, it was renamed to
get_spectrum
.With the new oversampling feature, it can happen, that the spectrum has an even length, which would result in a slightly shifted spectrum afterwards. To mitigate this a
trim
argument was introduced that removes the Nyquist frequency.This PR also introduces a
get_psd
method to calculate the power spectral density of a set of given coefficients.Breaking Changes
sample_coefficients
toget_spectrum