Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Init strategy #45

Merged
merged 14 commits into from
Sep 30, 2024
Merged

Init strategy #45

merged 14 commits into from
Sep 30, 2024

Conversation

stroblme
Copy link
Member

This PR resolves #41 by

  • moving the parameter initialization to a separate method

The PR is chained with #44 because of non-failing tests.

Melvin Strobl added 14 commits September 23, 2024 11:25
splitted tests
9477162 
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
fixed cache test
4053756 
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
naming
8ada2b2 
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
added batch dim merge
e47e015 
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
fixed param
b65e9e2 
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
fixed parity test
b4148f5 
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
added failing test from before to the proper test fct
1c0ff92 
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
adapted badges
4576a89 
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
added poetry tests
4c20f8c 
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
fixed unused imports
4199ce3 
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
fixed flake 8 poetry
97e134d 
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
fixed actions
81854c4 
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
moved init to separate method
16a9109 
Signed-off-by: Melvin Strobl <lc3267@kit.edu>
Merge branch 'tests' into init-strategy
34a7b01
@stroblme stroblme requested a review from majafranz September 23, 2024 11:03
@pep8speaks
Copy link

Hello @stroblme! Thanks for opening this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 216:37: E203 whitespace before ':'
Line 216:50: E203 whitespace before ':'
Line 217:54: E203 whitespace before ':'
Line 217:67: E203 whitespace before ':'

@stroblme
Copy link
Member Author

ignoring pep because we have gh actions

majafranz
majafranz approved these changes Sep 30, 2024
View reviewed changes
Copy link
Collaborator

@majafranz majafranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! Looks good to me. Thanks a lot 🚀

@majafranz majafranz merged commit e246996 into main Sep 30, 2024
1 check passed
@majafranz majafranz deleted the init-strategy branch November 15, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majafranz majafranz majafranz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FR] Move param initialization to separate method
3 participants
@stroblme @pep8speaks @majafranz