Registration disabled, hide register and login form except for OIDC providers

[samip5]

Describe the bug

When a Synapse Matrix server has disabled registration, the links should be hidden for registration aswell as hide login input fields but show OIDC authentication provider links.

To Reproduce

Steps to reproduce the behavior:

1. Deploy Matrix Synapse with OIDC auth only enabled, registration disabled.
2. Deploy Cinny, change default HS url.
3. Go to Cinny and see that OIDC provider link has appeared but the login from and registration link is still visiable.

Expected behavior

The login input fields would be hidden and registration link too so only shown would be OIDC/SSO provider login method.

Screenshots

Additional context

Element does it like this:

[simonwuelker]

@ajbura why is this closed? It is not fixed.

[ajbura]

@Wuelle It has been fixed. Why you think it’s not fixed?

[simonwuelker]

Because this Registration link

still shows up, despite registration being disabled. Once you click it, you get

Two things:

• In the first screenshot, the "Dont have an account? Register" link should not appear.
• In the second screenshot, the "Already have an account? Login" link should not appear.
  (This is part of the issue the OP was referring to, so i did not open a new issue and commented on this one instead)
  I am using v1.6.1

[ajbura]

@Wuelle OP was referring to hide login and registration form not these links.

The reason we’ve kept these links because,
a). User can know that registrations are disabled on xyz homeserver when they are on login page.
b). And if someone goes to registration page then can come back on login page.

[simonwuelker]

OP was referring to hide login and registration form not these links.

from the original issue:

The login input fields would be hidden and registration link too so only shown would be OIDC/SSO provider login method.

If you already thought about removing the link and decided against it, fair enough.
IMO the better way of letting the user know registration is disabled would be by not showing a registration link.