Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix corner case in handling of short syntax in CaSH #139

Closed
jtnelson opened this issue Jan 27, 2016 · 5 comments
Closed

Fix corner case in handling of short syntax in CaSH #139

jtnelson opened this issue Jan 27, 2016 · 5 comments
Assignees
@dubex
Labels
bug
Milestone
sprint_2016_2

Comments

@jtnelson
Copy link
Member

Related to GH-135, SyntaxTools is not converting "diff" to concourse.diff in the following input

diff "1452270300424000", time("last week")

To fix this, we need to modify the regex in SyntaxTools#parseShortInvokedMethods to match any word followed by a paren OR space
@jtnelson jtnelson added the bug label Jan 27, 2016
@jtnelson jtnelson added this to the sprint_2016_2 milestone Jan 27, 2016
@jtnelson
Copy link
Member Author

@dubex this is the fix we discussed last week. Just adding it here for tracking purposes

@jtnelson jtnelson reopened this Jul 15, 2016
@dubex
Copy link
Collaborator

dubex commented Jul 28, 2016 •
edited
Loading

Please describe the test case for which it got reopened. Thanks.

@jtnelson
Copy link
Member Author

@dubex same test case, i think i just accidentally closed it the first time and that is why i reopened it

@jtnelson
Copy link
Member Author

jtnelson commented Mar 5, 2022

Same as #465

jtnelson added a commit that referenced this issue Mar 5, 2022
@jtnelson
fix failing unit tests and update unit test for GH-139
9fc7122
jtnelson added a commit that referenced this issue Mar 5, 2022
@jtnelson
GH-463: Fixed a bug that caused Concourse Shell to fail to parse some…
f813cd6 
… short syntax (#465)

* GH-463: Fixed a bug that caused Concourse Shell to fail to parse short syntax within statements containing an open parenthesis

* upgrade groovy-all dependency to prevent version conflict with concourse-commons

* fix failing unit tests and update unit test for GH-139

* use list instead of stream

* update changelog
@jtnelson
Copy link
Member Author

jtnelson commented Mar 5, 2022

Fixed with f813cd6

@jtnelson jtnelson closed this as completed Mar 5, 2022
jtnelson added a commit that referenced this issue Mar 5, 2022
@jtnelson
GH-463: Fixed a bug that caused Concourse Shell to fail to parse some…
8a6d967 
… short syntax (#465)

* GH-463: Fixed a bug that caused Concourse Shell to fail to parse short syntax within statements containing an open parenthesis

* upgrade groovy-all dependency to prevent version conflict with concourse-commons

* fix failing unit tests and update unit test for GH-139

* use list instead of stream

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dubex dubex

Labels
bug
Projects
None yet
Milestone
sprint_2016_2
Development

No branches or pull requests
2 participants
@jtnelson @dubex