Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elfinfo should not have a hard requirement on disassembler #3

Open
Ecco opened this issue May 20, 2022 · 3 comments
Open

Elfinfo should not have a hard requirement on disassembler #3

Ecco opened this issue May 20, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@Ecco
Copy link

Ecco commented May 20, 2022

Sometimes you just want to parse elf files without disassembling them 😄

@cilliemalan
Copy link
Owner

elfinfo doesn't depend on disassembler. If it does this is a mistake. What issue are you encountering?

The node dependency is currently required...hopefully I can figure out how to make it optional in the future.

cilliemalan added a commit that referenced this issue May 24, 2022
@Ecco
Copy link
Author

Ecco commented May 24, 2022

Here's the error I get:

ERROR in ./node_modules/elfinfo/dist/src/disassembly.js 4:23-46
Module not found: Error: Can't resolve 'disassembler' in './node_modules/elfinfo/dist/src'

@cilliemalan
Copy link
Owner

@Ecco It seems I had pushed a broken build to npm. Unfortunately due to negligence on my part the code for that version has been lost (apart from what is on npm). To alleviate the problem I have pushed a "new" version to npm (and github!) 0.4.0-beta which is not substantially different from 0.2.0-beta. When I have some free time again I will work at reintegrating the 0.3.0-beta changes back in and get it working.

You can install the "fixed" version either with yarn add elfinfo@0.4.0-beta or npm i elfinfo@0.4.0-beta

I have tested this with the code from the readme.

@cilliemalan cilliemalan added the bug Something isn't working label May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants