fixup server address when port is not present #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willfindlay
force-pushed
the
pr/willfindlay/fixup-server-addr
branch
from
4633cf0 to
687fee6
Compare
Signed-off-by: William Findlay <will@isovalent.com>
Some recent changes to the way we input the address string in Helm have introduced an unfortunate compatibility breakage with the old default values which did not include a port number in the address string. To provide backward compatibility here, let's just assume a default of `:54321` when the port is not present. Signed-off-by: William Findlay <will@isovalent.com>
willfindlay
force-pushed
the
pr/willfindlay/fixup-server-addr
branch
from
687fee6 to
d88a6ed
Compare
tpapagian
approved these changes
Apr 7, 2023
tixxdz
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some recent changes to the way we input the address string in Helm have introduced an
unfortunately compatibility breakage with the old default values which did not include
a port number in the address string. To provide backward compatibility here, let's just
assume a default of
:54321when the port is not present.