Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tetragon: Unflake the TestGeneratedExecEvents test #3141

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

olsajiri
Copy link
Contributor

On slow server the test might fails to start exporter fast enough making the test fail, because events did not get stored.

Moving the tetragonExecuteCtx into separate process and adding extra 5 tries on checking up on the exported file.

On slow server the test might fails to start exporter fast enough
making the test fail, because events did not get stored.

Moving the tetragonExecuteCtx into separate process and adding extra
5 tries on checking up on the exported file.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
@olsajiri olsajiri added the release-note/minor This PR introduces a minor user-visible change label Nov 19, 2024
@olsajiri olsajiri marked this pull request as ready for review November 19, 2024 14:57
@olsajiri olsajiri requested a review from a team as a code owner November 19, 2024 14:57
@olsajiri olsajiri requested a review from tpapagian November 19, 2024 14:57
Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm except maybe something with assert.NoError(t, err) that might not be correct.

cmd/tetragon/main_test.go Show resolved Hide resolved
@olsajiri olsajiri merged commit 5d50928 into main Nov 20, 2024
40 of 41 checks passed
@olsajiri olsajiri deleted the pr/olsajiri/fixes branch November 20, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants