Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport/v1.2] Add support to exclude valid processes from dump processCache #3104

Merged
merged 6 commits into from
Nov 13, 2024

Conversation

tpapagian
Copy link
Member

@tpapagian tpapagian commented Nov 13, 2024

mtardy and others added 4 commits November 13, 2024 09:52
[upstream commit 606bc42]

I realized we used camelCase in a tetra subcmd and in the debug API.
Changing the debug API should not be a problem as it was not yet
released and it's a debug feature. The subcmd has an alias because it
was easy.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
[upstream commit 8b2aa36]

This allows the command to return != 0 return error code on failure as
expected.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
[upstream commit 69ea3f8]

When dumping a full process cache (around 65K entries) the gRPC client
could not handle a response of this size. This makes it possible to
configure it on demand if needed.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
[upstream commit 7e4b379]

When running ./tetra dump processcache we can get all processes in the
user-space process cache. Out of these, we can use --skip-zero-refcnt to
exclude processes with refCnt equals to 0. These are processes that will
be removed from the processCache soon.

Out of these processes with refCnt not equal to 0, most of them are
nornal running processes that also exist in the execve_map.

This patch adds another command line option
--exclude-execve-map-processes that excludes processes that exist in the
execve_map.

The remaining processes (if any) have possibly an error in the reference
counting.

Signed-off-by: Anastasios Papagiannis <tasos.papagiannnis@gmail.com>
@tpapagian tpapagian requested a review from a team as a code owner November 13, 2024 08:03
@tpapagian tpapagian requested review from olsajiri and removed request for a team November 13, 2024 08:03
@tpapagian tpapagian added the release-note/misc This PR makes changes that have no direct user impact. label Nov 13, 2024
tpapagian and others added 2 commits November 13, 2024 13:22
[upstream commit 65ef270]

CNCF stopped funding actuated arm64 runners but GitHub now proposes
their own runners part of the GitHub offering.

Signed-off-by: Mahe Tardy <mahe.tardy@gmail.com>
Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
Copy link
Contributor

@kevsecurity kevsecurity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tpapagian tpapagian merged commit 0455f39 into v1.2 Nov 13, 2024
43 checks passed
@tpapagian tpapagian deleted the pr/apapag/backport_2949_v1.2 branch November 13, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants