Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crd: Added shortnames and catagory for Tetragon CRDs #3065

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

PhilipSchmid
Copy link
Collaborator

@PhilipSchmid PhilipSchmid commented Nov 1, 2024

Let's slightly improve the Tetragon UX for lazy people like I am 😄.

  • podinfo -> tgpi
  • tracingpolicy -> tgtp
  • tracingpoliciesnamespaced -> tgtpn

Furthermore, it's now possible to interact with user-relevant CRs (all besides PodInfo) at the same time via the tetragon category.

BTW, Cilium does the same for every Cilium CRD.

crd: Added shortnames and catagory for Tetragon CRDs

@PhilipSchmid PhilipSchmid added release-note/misc This PR makes changes that have no direct user impact. area/crd Related to Kubernetes Custom Resource Definitions labels Nov 1, 2024
@PhilipSchmid PhilipSchmid self-assigned this Nov 1, 2024
@PhilipSchmid PhilipSchmid force-pushed the pr/philip/crd_shortnames branch 2 times, most recently from b490ffb to 8af7b2e Compare November 1, 2024 09:13
Signed-off-by: Philip Schmid <phisch@cisco.com>
@PhilipSchmid PhilipSchmid force-pushed the pr/philip/crd_shortnames branch from 8af7b2e to 954d963 Compare November 4, 2024 08:54
@PhilipSchmid PhilipSchmid changed the title crd: Added shortnames for Tetragon CRDs crd: Added shortnames and catagory for Tetragon CRDs Nov 4, 2024
@PhilipSchmid
Copy link
Collaborator Author

PhilipSchmid commented Nov 4, 2024

Example usage:

$ k get tgpi
NAME                                      AGE
cilium-5ntnd                              15s
cilium-d5nh4                              15s
cilium-mpclj                              15s
cilium-operator-78cbc7d94d-2vdvd          15s
cilium-operator-78cbc7d94d-7dhq7          15s
cilium-rnx9z                              15s
cilium-sw7t6                              15s
coredns-6d77cf9f7-rd7xh                   15s
coredns-6d77cf9f7-rzdr7                   15s
hubble-relay-bf5c486f9-tt8d8              15s
kube-apiserver-ip-10-0-100-221            14s
kube-apiserver-ip-10-0-101-120            15s
kube-apiserver-ip-10-0-102-11             15s
kube-controller-manager-ip-10-0-100-221   15s
kube-controller-manager-ip-10-0-101-120   15s
kube-controller-manager-ip-10-0-102-11    15s
kube-proxy-9wbzv                          15s
kube-proxy-bzk25                          15s
kube-proxy-j7xm5                          15s
kube-proxy-lpqkp                          15s
kube-proxy-vhmhd                          15s
kube-scheduler-ip-10-0-100-221            15s
kube-scheduler-ip-10-0-101-120            15s
kube-scheduler-ip-10-0-102-11             15s
metrics-server-566c79d6df-jrlh6           15s
tetragon-b97xs                            15s
tetragon-dqvtp                            15s
tetragon-m4wjr                            15s
tetragon-operator-7656844cd7-2vtxf        15s
tetragon-p6jd9                            15s
tetragon-rsbg8                            15s
$ k get tgtp
NAME                     AGE
bpf-load                 2m12s
monitor-kernel-modules   2m12s
monitor-mounts           2m12s
monitor-ptrace           2m12s
privileges-change        2m12s
$ k get tetragon
NAME                                             AGE
tracingpolicy.cilium.io/bpf-load                 2m16s
tracingpolicy.cilium.io/monitor-kernel-modules   2m16s
tracingpolicy.cilium.io/monitor-mounts           2m16s
tracingpolicy.cilium.io/monitor-ptrace           2m16s
tracingpolicy.cilium.io/privileges-change        2m16s

@PhilipSchmid PhilipSchmid marked this pull request as ready for review November 4, 2024 09:55
@PhilipSchmid PhilipSchmid requested a review from a team as a code owner November 4, 2024 09:55
@PhilipSchmid PhilipSchmid requested review from tixxdz, kkourt, lambdanis and mtardy and removed request for tixxdz November 4, 2024 09:55
Copy link
Contributor

@lambdanis lambdanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pkg/k8s/apis/cilium.io/v1alpha1/types.go Outdated Show resolved Hide resolved
@lambdanis lambdanis added release-note/minor This PR introduces a minor user-visible change and removed release-note/misc This PR makes changes that have no direct user impact. labels Nov 6, 2024
@lambdanis
Copy link
Contributor

I changed the release-note label from misc to minor, as it is a user-visible change. Let me know if you think it should rather be misc.

Copy link
Contributor

@kkourt kkourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, laziness approved!

Copy link
Member

@mtardy mtardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree! Unsure tgpi is super useful but why not. Tetragon category is cool though!

Applied for all user-relevant CRDs. Not for PodInfo.

Signed-off-by: Philip Schmid <phisch@cisco.com>
@PhilipSchmid PhilipSchmid force-pushed the pr/philip/crd_shortnames branch from ba788ec to 5a85682 Compare November 7, 2024 15:46
Copy link

netlify bot commented Nov 7, 2024

Deploy Preview for tetragon ready!

Name Link
🔨 Latest commit 5a85682
🔍 Latest deploy log https://app.netlify.com/sites/tetragon/deploys/672ce0c759d3f800081e0092
😎 Deploy Preview https://deploy-preview-3065--tetragon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lambdanis lambdanis merged commit 0333520 into main Nov 8, 2024
46 checks passed
@lambdanis lambdanis deleted the pr/philip/crd_shortnames branch November 8, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/crd Related to Kubernetes Custom Resource Definitions release-note/minor This PR introduces a minor user-visible change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants