-
Notifications
You must be signed in to change notification settings - Fork 376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
version: add version string to metrics #3035
Conversation
4428023
to
2228f92
Compare
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure!! You just miss some metrics doc generation.
I think the problem is that the docs are based on the SHA of the version, so every time I update it the SHA changes. I'll try to find a workaround. |
Oh yes put a constant in there :) tetragon/cmd/tetragon-metrics-docs/metricsmd/metricsmd.go Lines 31 to 49 in c0e513f
|
Did something else. Happy to change it to what you suggested if it's an issue, but I think overriding Version also works. |
I think I would do it like Anna did with the rest of the values in there so that you don't touch the Makefile and we don't have two ways of doing the same thing. |
Before this patch: tetragon_build_info{commit="61b575c72b22aa8bb6d7ed8af2d3dbfee43f6307",go_version="go1.23.1",modified="true",time="2024-10-23T06:20:18Z"} 1 After: tetragon_build_info{commit="61b575c72b22aa8bb6d7ed8af2d3dbfee43f6307",go_version="go1.23.1",modified="true",time="2024-10-23T06:20:18Z",version="v1.3.0-pre.0-216-g61b575c72"} 1 Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
5394da8
to
0eea252
Compare
Good point! Pushed a new version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me like that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that's a useful label, thanks!
Before this patch:
tetragon_build_info{commit="61b575c72b22aa8bb6d7ed8af2d3dbfee43f6307",go_version="go1.23.1",modified="true",time="2024-10-23T06:20:18Z"} 1
After:
tetragon_build_info{commit="61b575c72b22aa8bb6d7ed8af2d3dbfee43f6307",go_version="go1.23.1",modified="true",time="2024-10-23T06:20:18Z",version="v1.3.0-pre.0-216-g61b575c72"} 1