-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tetragon: Use namespace in sensor policy directory #2987
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
October 10, 2024 11:52
8a23a0f
to
b1b658e
Compare
olsajiri
added
the
release-note/minor
This PR introduces a minor user-visible change
label
Oct 10, 2024
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
5 times, most recently
from
October 11, 2024 21:33
3927a9e
to
6a06273
Compare
Moving uprobes under tracing policy handler so we have generic sensors under one policy handler, which makes following changes simpler. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding namespace to policy directory name as prefix separated by ':' character, which is not allowed for namespace or policy name. We can have multiple namespaced policies with the same name which would collide in bpffs directory, so we reflect the namespace in the policy directory name, like: /sys/fs/bpf/ns1:policy/.. /sys/fs/bpf/ns2:policy/.. The policy without namespace stays the same (has no prefix), like: /sys/fs/bpf/policy/.. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Propagate the namespace value to generic sensors. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding policy object directly to SensorBuilder function so we can pass the namespace value to sensor object. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Adding sensor tests for namespace policy to verify we create proper policy directory and that they are properly removed. Signed-off-by: Jiri Olsa <jolsa@kernel.org>
olsajiri
force-pushed
the
pr/olsajiri/fixes
branch
from
October 13, 2024 09:31
c91de7d
to
411c97c
Compare
olsajiri
changed the title
Pr/olsajiri/fixes
tetragon: Use namespace in sensor policy directory
Oct 13, 2024
jrfastab
approved these changes
Oct 14, 2024
kkourt
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure the bpffs hierarchy tree works properly with namespaced policies.