podinfo: add a deleted pod cache #2930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
kkourt
added
the
release-note/misc
kkourt
force-pushed
the
pr/kkourt/podinfo-deleted-pod-cache
branch
from
492abf0 to
94af537
Compare
mtardy
approved these changes
Sep 17, 2024
This commit refactors the watcher code. It adds an error value (unused for now), and creates a new internal newK8sWatcher function. These two changes are going to be used by subsequent patches. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
Add a containerIDKey function for getting the container key from the full container id. It is intended for a subsequent patch. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
This does not change the semantics of the function. It is intended for a subsequent patch. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
This commit ads a test where a lookup for a pod via its container id happens
after the pod was deleted. This case, might happen if a pod is started and
deleted from the cache before user-space gets a chance to associate a pod with
an exec event.
Example:
go test ./pkg/watcher -test.run TestFastK8s -test.v
=== RUN TestFastK8s
watcher_test.go:32: time="2024-09-17T13:38:51+02:00" level=info msg="Initialized informer cache" count=0 informer=pod
watcher_test.go:95: adding pod
watcher_test.go:103: deleting pod
watcher_test.go:108:
Error Trace: /home/kkourt/src/tetragon/pkg/watcher/watcher_test.go:108
Error: Should be true
Test: TestFastK8s
Messages: deleted pod should be found
--- FAIL: TestFastK8s (0.10s)
FAIL
FAIL github.com/cilium/tetragon/pkg/watcher 0.118s
FAIL
Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
This commit adds an LRU cache that holds container ids for deleted pods. It is used to do pod association for pods that are deleted, and are no longer available in the pod cache. TestFastK8s now succeeds. Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
Signed-off-by: Kornilios Kourtis <kornilios@isovalent.com>
kkourt
force-pushed
the
pr/kkourt/podinfo-deleted-pod-cache
branch
from
94af537 to
4294881
Compare
|
Thanks for the review. Pushed a new version based on the feedback. Merging. |
Merged
kkourt
added
backport-pending/1.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a deleted pod cache for pod association. See commits.