Refactor & rename ratelimit metrics #2890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tetragon exposes a counter of events rate limited on export. Let's move this metric inside the exporter package, so that it's clear what it measures. Considering possible future development: * If there are multiple exporters, rate limits from all of them will be included in the same counter (no change) * If there are rate limiters not belonging to any exporter, their drops won't be counted (this changes here - before all drops by all rate limiters would be included in the metric) Mixing together drops from different exporters/rate limiters might be misleading, but not exposing some drops at all is problematic too. If this becomes an issue, a better solution would be probably exposing a counter per rate limiter (e.g. reuse existing RateLimiter.dropped field), labeled with a rate limiter identifier. But for now it seems a premature optimization. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
There are multiple places where events can be rate limited, and potentially there could be multiple things being rate limited. Let's make it clear from the metric name and description what and where is being rate limitted. Signed-off-by: Anna Kapuscinska <anna@isovalent.com>
lambdanis
added
area/metrics
✅ Deploy Preview for tetragon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mtardy
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tetragon exposes a counter of events rate limited on export. Let's move this
metric inside the exporter package, so that it's clear what it measures.
Considering possible future development:
included in the same counter (no change)
be counted (this changes here - before all drops by all rate limiters would
be included in the metric)
Mixing together drops from different exporters/rate limiters might be
misleading, but not exposing some drops at all is problematic too. If this
becomes an issue, a better solution would be probably exposing a counter per
rate limiter (e.g. reuse existing RateLimiter.dropped field), labeled with a
rate limiter identifier. But for now it seems a premature optimization.